US-45.9: interactive sessions implement in a change thread, a runner reviews (#917) - #918
Merged
Merged
Conversation
…unner reviews it (#917) The three rules that keep an interactive claim out of thread mode: review placement requires a dispatch-made claim, the merge gate reads an unplaced claim as pr, and the executor fences on a stage row a hand-made story lacks. The reviewer stays a runner, as Epic 45 decided after #901 and #905.
The first draft special-cased three rules. Every reader of a claim route derives it from one query, and the stage row only moves on runner reports, so the story now records an interactive claim route (mode, base branch, branch) where that query reads, tells placement and bulk claims apart by an explicit marker, lets the claimant report its own stage over the runner-reportable edges with head_sha, moves an intake-born row from queued at claim, starts the CI clock at the ci report, scopes the separation relaxation to claims with no lineage, requires lease renewal in the tool descriptions, fixes the separation test so it can run, and lists US-45.1 and US-45.7 as dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds US-45.9, the design for #917, as reasoned on the issue: #917 (comment)
The reviewer stays a runner. Epic 45 dropped key-holding reviewers deliberately after #901 and #905, and the runner socket is the only channel an implementing session cannot write to. A runner review session can still run
/code-review. The story instead closes the three rules that keep an interactive claim out of thread mode:prmode. An interactive claim now records the source mode when it is made. The mode is never read again, which keeps US-45.4: merge gate and stage machine speak checkpoints (v3, mode bound at placement) #908's promise that a change affects only later claims.The review itself still depends on loopctl-runner#55 and #56.
This is docs only: the story-schema test passes. The review gate is running.