Simple password tree plugin - #1
Merged
Merged
Conversation
chfanghr
marked this pull request as draft
September 19, 2023 11:08
adamczykm
reviewed
Sep 19, 2023
adamczykm
reviewed
Sep 19, 2023
| } | ||
|
|
||
| // FIXME: I have no idea what this should do | ||
| const getInputs = async (): Promise<string[]> => { |
Contributor
There was a problem hiding this comment.
What this does is basically implemented by fetchPublicInput you wrote
adamczykm
approved these changes
Sep 19, 2023
adamczykm
left a comment
Contributor
There was a problem hiding this comment.
I'm approving and merging the changes. Once we have an agreed-upon architecture for the plugin class we should probably make the storage a parameter and provide one with some persistence.
Contributor
|
The PR is marked as WIP, what is your plan? If this is about interaction with the MINA blockchain then it can be done in another PR as another plugin. |
chfanghr
marked this pull request as ready for review
September 20, 2023 09:10
adamczykm
pushed a commit
that referenced
this pull request
Oct 17, 2023
adamczykm
pushed a commit
that referenced
this pull request
Nov 28, 2023
adamczykm
pushed a commit
that referenced
this pull request
Nov 28, 2023
adamczykm
pushed a commit
that referenced
this pull request
Mar 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.