Skip to content

[Fix][TVMScript] Print truncdiv for int div - #156

Closed
cyx-6 wants to merge 2 commits into
mlc-ai:mlcfrom
cyx-6:printer-fix
Closed

cyx-6 wants to merge 2 commits into
mlc-ai:mlcfrom
cyx-6:printer-fix

Conversation

@cyx-6

@cyx-6 cyx-6 commented Mar 5, 2023

Copy link
Copy Markdown
Contributor

This PR fixes the output for T.Div(int, int). It will print T.truncdiv(int, int), instead of int / int, to avoid the integer division ambiguity in parser.

@cyx-6 cyx-6 changed the title [Fix]{TVMScript] Print truncdiv for int div [Fix][TVMScript] Print truncdiv for int div Mar 5, 2023
cyx-6 added 2 commits March 6, 2023 13:41
This PR fixes the output for `T.Div(int, int)`. It will print `T.truncdiv(int, int)`, instead of `int / int`, to avoid the integer division ambiguity in parser.
@junrushao

Copy link
Copy Markdown
Member

Perhaps we could close this PR and rebase to upstream once it's merged? apache/tvm#14200

@cyx-6

cyx-6 commented Mar 7, 2023

Copy link
Copy Markdown
Contributor Author

@junrushao Yes, this PR will be closed.

@cyx-6 cyx-6 closed this Mar 7, 2023
vinx13 pushed a commit to vinx13/mlc-relax that referenced this pull request May 8, 2023
shengxinhu pushed a commit to shengxinhu/relax-mlc that referenced this pull request Mar 26, 2025
This PR reorganizes the artifact structure. We now have two separate
types of directories to store the libs/weights/..., with one "prebuilt"
directory which holds all the prebuilt libs and weights downloaded from
internet, and other model directories that are generated by local
builds.

CLI and test scripts are updated accordingly for this change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants