Speed up clustering with adjacency matrix compacting and BLAS sign-flip reduction - #14057
Merged
Merged
Conversation
Member
Author
|
This is a fairly straightforward speedup after #13731 so I'll mark for merge-when-green |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #13731. Speeds up permutation cluster functions further:
signs @ Xreduction (should be memory safe, avoids "unsetting" the applied sign flips)Investigated the gains and drafted initial implementation with Claude Opus 4.8. I also had it run benchmarks with
py-spy(and just wall clock time) to ensure the gains were meaningful. I've also touch a couple examples that should execute faster as well.