Clean up old version usages and SPEC0 pin a few more deps - #14108
Merged
Conversation
larsoner
requested review from
agramfort,
drammock and
mscheltienne
as code owners
July 27, 2026 19:02
drammock
approved these changes
Jul 27, 2026
Member
There was a problem hiding this comment.
since this script is migrating to mne-tools repo soon, let's make sure these changes make it there too. cc @tsbinns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used Claude Opus 5 to look for places we had cruft / technical debt from old versions, and places that we should have TODO VERSION and don't. It found a lot, including a bug regarding buttons:
Click the Channel selection window and press b: on this branch every radio button fills in; on
mainonly the active one does.Also moves a few packages into SPEC0-checking (nilearn, dipy, nibabel, mne-qt-browser, numba) as it allows us to remove some old code / checks. And includes a tiny fix that hopefully helps CircleCI when there are
aptdownloading issues.Opus drafted the changes but I iterated until I was happy with them.