Skip to content

Fix notch spectrum fit - #14116

Merged
larsoner merged 2 commits into
mne-tools:mainfrom
cbrnr:followup-notch
Jul 31, 2026
Merged

Fix notch spectrum fit#14116
larsoner merged 2 commits into
mne-tools:mainfrom
cbrnr:followup-notch

Conversation

@cbrnr

@cbrnr cbrnr commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Implement comments by @larsoner from #14114. Sorry for the sloppy first PR!

@larsoner

Copy link
Copy Markdown
Member

pip-pre failures unrelated and @drammock is looking, thanks @cbrnr !

@larsoner
larsoner merged commit 2aeca09 into mne-tools:main Jul 31, 2026
30 of 35 checks passed
@cbrnr
cbrnr deleted the followup-notch branch July 31, 2026 16:39
larsoner added a commit to larsoner/mne-python that referenced this pull request Aug 4, 2026
* upstream/main: (35 commits)
  Fix bug with coreg scaling (mne-tools#14132)
  MAINT: Update code credit (mne-tools#14131)
  Fix bugs with dark mode panels (mne-tools#14109)
  Improve code credit workflow (mne-tools#14120)
  Align _AbstractRenderer.tube with the PyVista implementation (mne-tools#14125)
  Assign instead of compare when marking explicit zeros in spatio_temporal_dist_adjacency (mne-tools#14124)
  MAINT: Update pre-commit hook versions (mne-tools#14122)
  MAINT: Update dependency specifiers (mne-tools#14121)
  fix: correct typo in comment (mne-tools#14117)
  [dependabot]: Bump the actions group with 2 updates (mne-tools#14123)
  Fix` read_raw_eyelink()` failure when recording blocks are empty or starting with empty values (mne-tools#13571)
  ENH: Add `event_key` parameter to `read_raw_egi` for MFF event metadata (mne-tools#14086)
  fix for scipy sparse deprecations (mne-tools#14118)
  Fix notch spectrum fit (mne-tools#14116)
  Speed up notch filter spectrum fit (mne-tools#14114)
  fix MNE-RT links and update roadmap (mne-tools#14096)
  Clarify `docdict["filter_length_notch"]` (mne-tools#14113)
  Refactor test_plot_alignment_basic() (mne-tools#13472)
  BUG: Cleanup cHPI filtering using smooth interpolation (mne-tools#14112)
  Use redirector app (mne-tools#14111)
  ...

# Conflicts:
#	mne/tests/test_filter.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants