Skip to content

MRG, MAINT: Remove PySurfer from CircleCI - #7275

Closed
larsoner wants to merge 1 commit into
mne-tools:masterfrom
larsoner:ps
Closed

MRG, MAINT: Remove PySurfer from CircleCI#7275
larsoner wants to merge 1 commit into
mne-tools:masterfrom
larsoner:ps

Conversation

@larsoner

@larsoner larsoner commented Feb 1, 2020

Copy link
Copy Markdown
Member

@GuillaumeFavelier this should work at this point, right? CircleCI should maybe give us the answer.

@GuillaumeFavelier

GuillaumeFavelier commented Feb 1, 2020

Copy link
Copy Markdown
Contributor

this should work at this point, right?

In theory yes, I'm still interested by the results

@codecov

codecov Bot commented Feb 1, 2020

Copy link
Copy Markdown

Codecov Report

Merging #7275 into master will increase coverage by 1.38%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #7275      +/-   ##
=========================================
+ Coverage   88.41%   89.8%   +1.38%     
=========================================
  Files         447     447              
  Lines       80597   80598       +1     
  Branches    12878   12878              
=========================================
+ Hits        71260   72379    +1119     
+ Misses       6518    5391    -1127     
- Partials     2819    2828       +9

@GuillaumeFavelier

Copy link
Copy Markdown
Contributor

This made me realize that plot_parcellation.py uses PySurfer explicity:

https://17778-1301584-gh.circle-artifacts.com/0/dev/auto_examples/visualization/plot_parcellation.html#sphx-glr-auto-examples-visualization-plot-parcellation-py

But why Circle was happy?

@larsoner

larsoner commented Feb 3, 2020

Copy link
Copy Markdown
Member Author

Ahh there is still pip install -r requirements.txt which has PySurfer in there.

@GuillaumeFavelier

GuillaumeFavelier commented Feb 3, 2020

Copy link
Copy Markdown
Contributor

It seems like refactor is needed for plot_parcellation.py and plot_vector_source_estimates() (work in progress in #7060)

@larsoner

larsoner commented Feb 3, 2020

Copy link
Copy Markdown
Member Author

For plot_parcellation we can probably just change it to iterate over the labels and do brain.add_label for each one. I'll close for now but I'll add to your TODO list to do this once vector source estimates are taken care of

@larsoner larsoner closed this Feb 3, 2020
@larsoner
larsoner deleted the ps branch February 3, 2020 15:54
@GuillaumeFavelier GuillaumeFavelier mentioned this pull request Feb 3, 2020
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants