Skip to content

Fix initial_time in _TimeViewer - #7381

Merged
larsoner merged 1 commit into
mne-tools:masterfrom
GuillaumeFavelier:time_viewer_initial_time
Mar 4, 2020
Merged

Fix initial_time in _TimeViewer#7381
larsoner merged 1 commit into
mne-tools:masterfrom
GuillaumeFavelier:time_viewer_initial_time

Conversation

@GuillaumeFavelier

Copy link
Copy Markdown
Contributor

This PR fixes the default time value for _TimeViewer. The diff is very short, a connection with the slider was missing.

Closes #7379
It's an item of #7162

@GuillaumeFavelier

Copy link
Copy Markdown
Contributor Author

I believe this should solve your issue @SophieHerbst could you try it out?

@SophieHerbst

Copy link
Copy Markdown
Contributor

Yes, this works. Thank you @GuillaumeFavelier!

@larsoner

larsoner commented Mar 4, 2020

Copy link
Copy Markdown
Member

Failure is spurious and should be fixed by #7378, restarting

@larsoner
larsoner merged commit 3bde3d2 into mne-tools:master Mar 4, 2020
@larsoner

larsoner commented Mar 4, 2020

Copy link
Copy Markdown
Member

Thanks @GuillaumeFavelier

@GuillaumeFavelier GuillaumeFavelier mentioned this pull request Mar 4, 2020
86 tasks
AdoNunes pushed a commit to AdoNunes/mne-python that referenced this pull request Apr 6, 2020
AdoNunes pushed a commit to AdoNunes/mne-python that referenced this pull request Apr 6, 2020
@GuillaumeFavelier
GuillaumeFavelier deleted the time_viewer_initial_time branch June 11, 2020 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

stc.plot setting initial_time not working with time_viewer=True (PyVista)

3 participants