Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
177 commits
Select commit Hold shift + click to select a range
7ffd47a
WIP figure class proof-of-concept
drammock Jun 30, 2020
5808489
fix a few little things [ci skip]
drammock Jul 2, 2020
3511650
get basic callbacks working; instantiate w/ function
drammock Jul 3, 2020
2387c4f
WIP more callbacks
drammock Jul 6, 2020
5eaa1ab
fix zen mode toggle
drammock Jul 9, 2020
99de03c
finish callback skeleton; refactor browse_figure initializer
drammock Jul 10, 2020
7da98a6
make init take Raw instance; handle proj button
drammock Jul 11, 2020
6b6997a
move onclick func
drammock Jul 13, 2020
f94e961
fix init
drammock Jul 13, 2020
af65a88
comments
drammock Jul 13, 2020
80a1496
new class for ancillary figures; misc refactoring
drammock Jul 14, 2020
dd53910
fix import
drammock Jul 14, 2020
b69ed9f
rework class init logic
drammock Jul 14, 2020
c8c6aa5
add lasso selection handler
drammock Jul 15, 2020
7d48de0
get traces working(ish)
drammock Jul 16, 2020
fc48e4c
WIP: rewrite plot_raw [ci skip]
drammock Jul 17, 2020
a54f01d
fix scalebar plotting/toggling
drammock Jul 18, 2020
3d50a76
get scaling working
drammock Jul 22, 2020
a75c306
fix clipping, fix channel order, lots of cleanup
drammock Jul 23, 2020
6982dc9
scrolling works [ci skip]
drammock Jul 23, 2020
903b958
update ch names when scrolling; changing n traces works
drammock Jul 23, 2020
f11b6eb
grow/shrink duration working
drammock Jul 23, 2020
c1ac6be
comments
drammock Jul 24, 2020
af86f55
finally fix scaling all the way
drammock Jul 24, 2020
bf1575f
simplify
drammock Jul 24, 2020
f6533ac
enable clicking on time scrollbar; cleanup; work on projs [ci skip]
drammock Jul 25, 2020
a3ecd35
window title, projectors, projectors dialog all working
drammock Jul 27, 2020
abbe5be
WIP get annotation working [ci skip]
drammock Jul 28, 2020
9697e96
WIP annotations getting closer [ci skip]
drammock Jul 28, 2020
c7ab7cd
rework annotations UI [ci skip]
drammock Jul 30, 2020
8b1504a
fix annotation window event listeners [ci skip]
drammock Jul 30, 2020
15f3afc
doc
drammock Jul 30, 2020
f27be10
organize methods; remove cruft [ci skip]
drammock Jul 30, 2020
f22cf73
better naming; reset annotation label text after new label add
drammock Aug 1, 2020
239cff9
help dialog working [ci skip]
drammock Aug 5, 2020
587bab9
update help text
drammock Aug 5, 2020
ee13c04
broaden definition of "red" to exclude when annotating
drammock Aug 5, 2020
7fda794
WIP annotation selector [ci skip]
drammock Aug 6, 2020
a359820
comments [ci skip]
drammock Aug 6, 2020
b2b1801
click ch_name to mark bad works [ci skip]
drammock Aug 7, 2020
8b5bc5c
ordereddict for help text
drammock Aug 7, 2020
2721794
click to vscroll working
drammock Aug 7, 2020
d1ae65d
cruft
drammock Aug 7, 2020
f4fea4d
cleaner hscroll/vscroll clicking [ci skip]
drammock Aug 7, 2020
d42b469
click signal to mark bad; vline guide; tweak help text [ci skip]
drammock Aug 7, 2020
6f78b4b
WIP annotations [ci skip]
drammock Aug 8, 2020
f624040
persistent annotations; close_event handling [ci skip]
drammock Aug 11, 2020
0a1a7da
make info changes persistent
drammock Aug 11, 2020
8450f71
refactor annotation fig cleanup
drammock Aug 11, 2020
976549c
cleaner
drammock Aug 11, 2020
334a013
fix annotation dragging [ci skip]
drammock Aug 11, 2020
dba4c40
comments
drammock Aug 11, 2020
d210d04
help text, whitespace, comments
drammock Aug 12, 2020
4467e8f
get selections (mostly) working [ci skip]
drammock Aug 12, 2020
7f15a62
predefined selection working; cleaner cleanup inheritance [ci skip]
drammock Aug 13, 2020
f51bcb5
refactor child figures
drammock Aug 14, 2020
9c2fe98
lasso working; remove cruft; pydocstyle
drammock Aug 14, 2020
9cc963e
add instructions to selection fig
drammock Aug 14, 2020
6c58841
style sensorplot for predefined selections; refactor lasso styling
drammock Aug 14, 2020
5cc48a2
highlight sensors at init; tweak highlight styling [ci skip]
drammock Aug 14, 2020
41e30aa
butterfly works now [ci skip]
drammock Aug 15, 2020
1af7701
more consistent attribute tree
drammock Aug 15, 2020
fd47334
arrow keys scroll selection groups
drammock Aug 15, 2020
e8aa8e0
TODOs
drammock Aug 15, 2020
f45736b
up/down key scrolling when selections window focused
drammock Aug 16, 2020
e9cd018
refactor redraw; prevent custom sel if no lasso
drammock Aug 16, 2020
d12aaea
docstrings/comments [ci skip]
drammock Aug 16, 2020
e944cb1
event lines mostly working
drammock Aug 18, 2020
cb6daa9
add event texts
drammock Aug 19, 2020
7241862
fix event_color handling
drammock Aug 20, 2020
5a92c85
fix click vscroll in selection mode [ci skip]
drammock Aug 20, 2020
e07e95c
selection + butterfly working [ci skip]
drammock Aug 21, 2020
31bad91
WIP update sensor color when marking bad [ci skip]
drammock Aug 31, 2020
bd344d8
persistent bad color on sensor plot when interactively marking bads […
drammock Sep 1, 2020
4bd7b91
cleanup, comments
drammock Sep 2, 2020
51ac73e
update sensor highlight when toggling butterfly mode
drammock Sep 3, 2020
332a6eb
clean-ups
drammock Sep 4, 2020
aab9139
cleaner interaction of selection & butterfly modes
drammock Sep 4, 2020
9d57721
vectorize norming of traces
drammock Sep 4, 2020
cd08bc0
use LineCollection for data traces
drammock Sep 4, 2020
530576a
refactor annotations a little [ci skip]
drammock Sep 4, 2020
e2950ed
whitening works
drammock Sep 5, 2020
0fb7bb8
more subtle sensor styling
drammock Sep 5, 2020
d65df8e
refactor more setup into init [ci skip]
drammock Sep 5, 2020
ade7565
use rcParams instead of k/w for foreground/background colors
drammock Sep 6, 2020
bb0e7d3
sensor plot style tweak
drammock Sep 6, 2020
defb4a4
use red from cycle if possible for bad annotations
drammock Sep 6, 2020
c6bbfea
cruft
drammock Sep 6, 2020
2717e87
only show whitening help if noise_cov provided
drammock Sep 6, 2020
a7681b9
dedup
drammock Sep 6, 2020
fd34f33
fix: italicize channel names if whitened
drammock Sep 7, 2020
d2394d0
fix: redraw annotations when chan selection group changes
drammock Sep 7, 2020
e8d63a9
fix naming [ci skip]
drammock Sep 7, 2020
81a4687
restore "clamp" behavior
drammock Sep 8, 2020
96b7d00
fix for no proj
drammock Sep 8, 2020
c5ed22b
comments
drammock Sep 8, 2020
a2e8bdf
fix click radius
drammock Sep 8, 2020
827e74d
fix MPL deprecation warning [ci skip]
drammock Sep 8, 2020
9e01234
drawing speedups; minor fixes; TODOs [ci skip]
drammock Sep 8, 2020
55b7226
restore better label clicking logic
drammock Sep 9, 2020
73def30
better picking
drammock Sep 9, 2020
7700b80
draw bad channels behind
drammock Sep 9, 2020
e4e2ba4
comments [ci skip]
drammock Sep 9, 2020
efdeccc
vline
drammock Sep 11, 2020
68a1b56
draw idle
drammock Sep 11, 2020
9ea6b9f
bail early
drammock Sep 11, 2020
5007442
use blitting for vlines [ci skip]
drammock Sep 11, 2020
36beada
fix event labels; cleaner fg/bg color handling
drammock Sep 14, 2020
08d1007
fix: figsize from config
drammock Sep 14, 2020
22dbb81
prettier path shortening
drammock Sep 14, 2020
d3b3437
revert vline color
drammock Sep 14, 2020
669777c
cruft
drammock Sep 14, 2020
7e9a0cd
don't italicize misc chans [ci skip]
drammock Sep 14, 2020
a2d7b97
add (square!) checkbox for annotation edge dragging [ci skip]
drammock Sep 15, 2020
f85bb7d
flake
drammock Sep 15, 2020
9ed896f
make proj checkboxes square
drammock Sep 15, 2020
7327dff
show ch location on right-click
drammock Sep 15, 2020
e56e6f4
cleaner handling of child figures [ci skip]
drammock Sep 16, 2020
054e4c3
comments & return val [ci skip]
drammock Sep 18, 2020
1b0a8d8
better naming
drammock Sep 22, 2020
d8a75ca
don't add vline when toggling butterfly [ci skip]
drammock Sep 22, 2020
7ed5541
cleanup/reorg
drammock Sep 23, 2020
b090af8
remove old plot func
drammock Sep 23, 2020
9bd3bc9
remove cruft
drammock Sep 23, 2020
b5ebdce
move annotation highlight to back
drammock Sep 23, 2020
b6956ff
zorder management
drammock Sep 23, 2020
9cd381d
revert to Line2D
drammock Sep 23, 2020
4be153c
cruft
drammock Sep 23, 2020
2886993
make private
drammock Sep 23, 2020
76a2c37
revert toggle bad
drammock Sep 23, 2020
2dfc097
fix numpy deprecation warning
drammock Sep 23, 2020
0e319ea
cleaner
drammock Sep 23, 2020
612856e
fix comment
drammock Sep 23, 2020
9592f54
fix numpy dep warning?
drammock Sep 23, 2020
76cd48d
docstring wording
drammock Sep 24, 2020
7540c85
fix test
drammock Sep 24, 2020
5a9eccd
fix interaction of "order" and "group_by" params
drammock Sep 24, 2020
3a2938f
modernize
drammock Sep 24, 2020
47558ad
fix scalings
drammock Sep 24, 2020
9875c06
fix array/list
drammock Sep 24, 2020
e0793d2
cleaner; better names
drammock Sep 24, 2020
3bb7500
fix vscroll bug
drammock Sep 24, 2020
a6ae5a8
cruft
drammock Sep 24, 2020
476a42a
fix flake
drammock Sep 24, 2020
80178f9
fix error repr
drammock Sep 24, 2020
5672808
touch a couple tutorials
drammock Sep 24, 2020
9bfa3c9
better keypress testing
drammock Sep 25, 2020
d1f77ac
modernize
drammock Sep 25, 2020
b4d2ba4
coverage
drammock Sep 25, 2020
b2dfe33
hacky workaround for old MPL
drammock Sep 25, 2020
be121ec
fixed old MPL/numpy bugs
drammock Sep 26, 2020
7f0c4ac
fix flake
drammock Sep 27, 2020
6dea76a
fix fullscreen toggle
drammock Sep 27, 2020
76e31bf
fix: proj GUI too narrow for text
drammock Sep 27, 2020
9456b53
fix: picks/nchannels out of sync
drammock Sep 27, 2020
8d83452
clear hover line when exiting annotation mode
drammock Sep 28, 2020
1e8074b
clearer comment
drammock Sep 28, 2020
8a8b9f4
add toggle key for SSP window; small cleanup
drammock Sep 28, 2020
f317ac3
remove click-drag spectrum text from help window
drammock Sep 28, 2020
c731d28
coverage
drammock Sep 28, 2020
5511c4a
more prominent sensor highlighting
drammock Sep 28, 2020
7c0774d
restore button hover highlight
drammock Sep 28, 2020
8fc92af
fix tests
drammock Sep 28, 2020
2b2122a
remove right-click sensor plot; fix tests
drammock Sep 29, 2020
e813ef4
cruft
drammock Sep 29, 2020
49d876f
flake
drammock Sep 29, 2020
1f82c17
comments
drammock Sep 29, 2020
4b21681
remove conditional (min MPL always > condition)
drammock Sep 29, 2020
07afc8a
whitespace
drammock Sep 29, 2020
3b19b16
more coverage
drammock Sep 29, 2020
5b7e224
FIX: Test for old mpl
larsoner Sep 30, 2020
e5ca3e1
remove cruft
drammock Oct 12, 2020
e799c60
update ICA viz test
drammock Oct 12, 2020
db667c8
changes from Eric's review
drammock Oct 13, 2020
0fce9e4
pydocstyle
drammock Oct 13, 2020
d4c5da7
restore grad-before-mag plotting order
drammock Oct 14, 2020
10b9cef
fix botched rebase
drammock Oct 14, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions mne/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -476,6 +476,7 @@ def pytest_sessionfinish(session, exitstatus):
n = session.config.option.durations
if n is None:
return
print('\n')
try:
import pytest_harvest
except ImportError:
Expand Down
2 changes: 1 addition & 1 deletion mne/defaults.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ def _handle_default(k, v=None):
if isinstance(v, dict):
this_mapping.update(v)
else:
for key in this_mapping.keys():
for key in this_mapping:
this_mapping[key] = v
return this_mapping

Expand Down
4 changes: 2 additions & 2 deletions mne/preprocessing/tests/test_ica.py
Original file line number Diff line number Diff line change
Expand Up @@ -447,8 +447,8 @@ def test_ica_core(method, n_components, noise_cov, n_pca_components):

# test for gh-6271 (scaling of ICA traces)
fig = raw_sources.plot()
assert len(fig.axes[0].lines) in (5, 9)
for line in fig.axes[0].lines:
assert len(fig.mne.ax_main.lines) in (4, 8)
for line in fig.mne.ax_main.lines:
y = line.get_ydata()
if len(y) > 2: # actual data, not markers
assert np.ptp(y) < 15
Expand Down
8 changes: 5 additions & 3 deletions mne/selection.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
# License: BSD (3-clause)

from os import path
from collections import OrderedDict

import numpy as np

Expand Down Expand Up @@ -168,9 +169,10 @@ def _divide_to_regions(info, add_stim=True):
if len(stim_ch) > 0:
for region in [lf, rf, lo, ro, lp, rp, lt, rt]:
region.append(info['ch_names'].index(stim_ch[0]))
return {'Left-frontal': lf, 'Right-frontal': rf, 'Left-parietal': lp,
'Right-parietal': rp, 'Left-occipital': lo, 'Right-occipital': ro,
'Left-temporal': lt, 'Right-temporal': rt}
return OrderedDict([('Left-frontal', lf), ('Right-frontal', rf),
('Left-parietal', lp), ('Right-parietal', rp),
('Left-occipital', lo), ('Right-occipital', ro),
('Left-temporal', lt), ('Right-temporal', rt)])


def _divide_side(lobe, x):
Expand Down
Loading