MRG: Add some parameters to create_3d_figure - #8166
Merged
GuillaumeFavelier merged 3 commits intoAug 27, 2020
Merged
Conversation
agramfort
approved these changes
Aug 27, 2020
larsoner
approved these changes
Aug 27, 2020
larsoner
left a comment
Member
There was a problem hiding this comment.
LGTM, feel free to merge once CIs come back happy @GuillaumeFavelier
marsipu
pushed a commit
to marsipu/mne-python
that referenced
this pull request
Oct 14, 2020
* Add some parameters to create_3d_figure * Fix docstring * Improve coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the parameters
sceneandsmooth_shadingto the public functioncreate_3d_figure()to make it more flexible.Closes #8154