MRG, FIX: retain reference to lasso.selection without blocking - #8469
Merged
Conversation
Member
Author
|
@mmagnuski this works for me in local testing, can you confirm? |
drammock
force-pushed
the
fix-lasso-selection
branch
from
November 3, 2020 20:03
1908c2e to
169f774
Compare
Member
|
@drammock I can confirm this fixes the problem, thanks! |
Member
Author
Member
|
Travis minimal fails, there is a fix in #8477 |
Member
|
(but it will conflict with the changes here) |
Member
Author
we can merge that one first, I don't mind rebasing. |
drammock
force-pushed
the
fix-lasso-selection
branch
from
November 4, 2020 15:23
169f774 to
950caed
Compare
larsoner
reviewed
Nov 4, 2020
drammock
force-pushed
the
fix-lasso-selection
branch
from
November 4, 2020 22:10
950caed to
ffa685b
Compare
drammock
force-pushed
the
fix-lasso-selection
branch
from
November 4, 2020 22:33
ffa685b to
804dc47
Compare
Member
|
Thanks @drammock ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it so that the list of sensors returned by
plot_sensors(..., kind='select')will continue to be updated by figure interactions even ifblock=False. It restores previous behavior that was broken by #7955.