FIX: vertices - #8611
Merged
Merged
Conversation
Member
|
Can you add a unit test that would have caught this? Having to hear about these sorts of problems from CircleCI is not as nice as local |
drammock
reviewed
Dec 4, 2020
| @@ -1907,8 +1907,8 @@ def _plot_stc(stc, subject, surface, hemi, colormap, time_label, | |||
| for hi, hemi in enumerate(hemis): | |||
Member
There was a problem hiding this comment.
I think with this change you no longer need hi or enumerate
hoechenberger
approved these changes
Dec 7, 2020
Member
|
@GuillaumeFavelier We got a CI segfault on Py3.8, not sure if related? |
Contributor
Author
|
I'll investigate because it's close to the test I modified. |
Member
|
Restarted -- I think I've seen a spurious macOS test failure like this before. Probably something having to do with closing windows / garbage collection / Qt / VTK |
agramfort
approved these changes
Dec 7, 2020
Member
|
Thanks @GuillaumeFavelier ! Hopefully CircleCI goes back to green now |
86 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes hemi logic in stc.
Closes #8609