You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently when Deckard detects an orientation change, it'll run a isLandscape check by dividing window's height and width and compares it to compareRatio. At this moment, the window height and width values are still based on the initial orientation thus incorrectly return isLandscape as true/false when switching orientations.
Upon some testing, it appears using the resize event instead of orientationchange will yield consistent results on Android as the window height and width are correctly calculated.
Tested on Nexus 6P (Chrome) and Galaxy Note 5's Chrome Browser and "Samsung Internet Browser".
Currently when Deckard detects an orientation change, it'll run a
isLandscapecheck by dividing window's height and width and compares it tocompareRatio. At this moment, the window height and width values are still based on the initial orientation thus incorrectly returnisLandscapeas true/false when switching orientations.Upon some testing, it appears using the
resizeevent instead oforientationchangewill yield consistent results on Android as the window height and width are correctly calculated.Tested on Nexus 6P (Chrome) and Galaxy Note 5's Chrome Browser and "Samsung Internet Browser".