fix(opengraph): migrate to v2 opensea nft metadata collection stats endpoint - #125
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: f8c73a4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
stephancill
force-pushed
the
fix/opensea-collection-stats-v2
branch
from
December 15, 2023 21:35
94e12d3 to
f8c73a4
Compare
Contributor
|
lgtm |
davidfurlong
approved these changes
Dec 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
The opengraph endpoint currently doesn't return NFT metadata because the v1 endpoint for collection stats has been removed from the OpenSea API as per the response messsage:
This change migrates to the v2 opensea API, which does unfortunately not return the number of items in the collection. Hence the
itemCountproperty of the NFT response now returns 0. A separate issue will be opened to address this.Merge Checklist