Skip to content

fix: general integration readiness patches - #94

Merged
davidfurlong merged 19 commits into
mainfrom
fix/integration-improvements
Dec 6, 2023
Merged

fix: general integration readiness patches#94
davidfurlong merged 19 commits into
mainfrom
fix/integration-improvements

Conversation

@stephancill

@stephancill stephancill commented Nov 24, 2023

Copy link
Copy Markdown
Contributor
  • Horizontal Layout: Replace tailwind spacing with gap for compatibility reasons
  • Fix absolute layout on card.tsx
  • Add bold, secondary, regular variants to text component
  • Only render the first matched miniapp
  • Try fallback opengraph matcher if local fetcher doesn't match any images
  • User objects in metadata response can be a full FarcasterUser object (opengraph response) or only a partial object with only the fid (metadata response)

Includes/depends on #81

Outstanding integration issues:

  • video.tsx component global style import causes issues with nextjs (only when not using app router)
  • Can't make use of custom image rendering techniques i.e. the @next/image component

Fixes #98

@changeset-bot

changeset-bot Bot commented Nov 24, 2023

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c9c874f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Nov 24, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2023 6:12pm
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2023 6:12pm
example-nextjs-shadcn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2023 6:12pm

Comment thread docs/pages/integrate.mdx Outdated
Comment thread examples/api/src/app/api/open-graph/lib/util.ts Outdated
@stephancill
stephancill force-pushed the fix/integration-improvements branch from 13ef63e to 9e461bd Compare November 25, 2023 17:15
@stephancill
stephancill force-pushed the fix/integration-improvements branch from 9e461bd to 6dcd2c3 Compare November 25, 2023 17:24
@stephancill
stephancill force-pushed the fix/integration-improvements branch from e2f4131 to 56da768 Compare November 30, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

example-nextjs: Dark mode remove embed icon has a styling bug

2 participants