mcp: limit SSE discover supportedVersions to SSE-defined revisions - #1121
Merged
guglielmo-san merged 2 commits intoAug 5, 2026
Merged
guglielmo-san merged 2 commits into
guglielmo-san merged 2 commits into
Conversation
arimu1
force-pushed
the
fix/sse-supported-versions-1112
branch
from
August 4, 2026 00:16
319375e to
600f07b
Compare
Contributor
Author
|
Rebased onto current Conflict resolution: kept main's discover Tip |
Comment on lines
+906
to
+908
| // With SSE ProtocolVersionSupporter filtering out 2026-07-28, negotiate | ||
| // returns a legacy revision so InitializeParams stays nil and Modern-first | ||
| // clients can fall back to the legacy initialize handshake (#1112). |
Contributor
There was a problem hiding this comment.
i would remove this comment
Contributor
Author
There was a problem hiding this comment.
Removed — agreed, the existing transport gate comment already covers this.
HTTP+SSE is only defined by older MCP revisions. SSEServerTransport now implements ProtocolVersionSupporter so server/discover does not advertise 2026-07-28 (stdio + Streamable HTTP only). Also avoid marking the session initialized from discover when the requested version is not transport-supported, so Modern-first clients can fall back to the legacy initialize handshake over SSE. Fixes modelcontextprotocol#1112
Address review: the SSE ProtocolVersionSupporter path is covered by the existing transport gate comment; no need for the extra modelcontextprotocol#1112 note.
arimu1
force-pushed
the
fix/sse-supported-versions-1112
branch
from
August 5, 2026 13:14
39d7f61 to
1e34846
Compare
guglielmo-san
approved these changes
Aug 5, 2026
Contributor
|
@arimu1 thank you for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NewSSEHandlersessions were advertising2026-07-28inserver/discoversupportedVersions. That revision only defines stdio and Streamable HTTP, not the deprecated HTTP+SSE binding, so Modern-first clients could negotiate a revision the transport cannot honour.Changes
ProtocolVersionSupporteronSSEServerTransportsofilterSupportedVersionsexcludes>= 2026-07-28(matching the streamable transport's version gate pattern).Server.discover, only set sessionInitializeParamswhen the requested version is actually supported by the transport. Without this, a discover probe that returns only legacy versions still marked the session initialized, and the client's fallbackinitializefailed withduplicate "initialize" received.Fixes #1112
Test plan
go test ./...go test ./mcp/ -run 'TestSSE|TestInMemory_E2E_Discover|TestStreamableStateful_AcceptsDiscover|TestStreamableHTTP_E2E_Discover|TestClientConnectDiscover'Assistance: human-reviewed AI assistance used for implementation.