Skip to content

add minimal tests for the SSE transport#151

Merged
jspahrsummers merged 16 commits into
mainfrom
merrill/tests-for-sse
Jan 15, 2025
Merged

add minimal tests for the SSE transport#151
jspahrsummers merged 16 commits into
mainfrom
merrill/tests-for-sse

Conversation

@nick-merrill

@nick-merrill nick-merrill commented Jan 14, 2025

Copy link
Copy Markdown
Contributor

Motivation and Context

As #109 points out, we do not have any testing around the SSE transport for this SDK. This change adds some minimal tests to make sure the SSE transport is working as expected.

How Has This Been Tested?

This is just tests.

Breaking Changes

None

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Test improvements only

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

We should follow on with some more SSE tests, but hopefully this gives us a reasonable testing framework for the SSE transport such that more tests can be added easily. 🤞

@nick-merrill
nick-merrill marked this pull request as ready for review January 14, 2025 17:12

@jspahrsummers jspahrsummers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jspahrsummers
jspahrsummers merged commit 4c71c61 into main Jan 15, 2025
@jspahrsummers
jspahrsummers deleted the merrill/tests-for-sse branch January 15, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants