Skip to content

refactor: extract request and notification handling#166

Merged
dsp-ant merged 1 commit into
mainfrom
davidsp/refactor
Jan 24, 2025
Merged

refactor: extract request and notification handling#166
dsp-ant merged 1 commit into
mainfrom
davidsp/refactor

Conversation

@dsp-ant

@dsp-ant dsp-ant commented Jan 23, 2025

Copy link
Copy Markdown
Member

Summary

  • Extract request and notification handling into separate methods
  • Improve code organization and readability
  • Prepare for request cancellation support

Test plan

  • Run all tests
  • Verify request handling still works
  • Test notification handling

Depends on #165

@jerome3o-anthropic jerome3o-anthropic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dsp-ant
dsp-ant force-pushed the davidsp/types-2024-11-05 branch from 50e60d7 to bd74227 Compare January 24, 2025 09:53
Base automatically changed from davidsp/types-2024-11-05 to main January 24, 2025 09:53
@dsp-ant
dsp-ant dismissed jerome3o-anthropic’s stale review January 24, 2025 09:53

The base branch was changed.

@dsp-ant
dsp-ant merged commit 5f537a0 into main Jan 24, 2025
@dsp-ant
dsp-ant deleted the davidsp/refactor branch January 24, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants