fix: stamp server info on graceful subscription results - #1078
Merged
DaleSeo merged 2 commits intoJul 29, 2026
Conversation
DaleSeo
approved these changes
Jul 29, 2026
Merged
9 tasks
Member
|
Just for context, I initially implemented the shape documented in SEP-2575 in #1000. However, the final spec added a graceful result for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stamp the server implementation identity into the final result produced when a
subscriptions/listenhandler completes gracefully.Motivation and Context
The MCP 2026-07-28 specification says servers SHOULD include
io.modelcontextprotocol/serverInfoin every result's_meta.ServerHandler::listenreturnsResult<(), McpError>, and rmcp constructs thefinal
SubscriptionsListenResultonly after the handler returns. Applicationstherefore cannot add this metadata themselves.
This PR intentionally covers only the graceful
subscriptions/listenresultsynthesized by rmcp after the application handler returns. SDK-wide stamping of
application-produced results is a separate concern.
How Has This Been Tested?
the server implementation identity.
non-local-feature passes.
cargo clippy --all-targets --all-features -- -D warnings.cargo +nightly fmt --all -- --check.Breaking Changes
None. This adds missing response metadata without changing the handler API.
Types of changes
Checklist
Additional context
The request path captures
ServerInfoonce before establishing thesubscription, so capability filtering and the eventual server identity come
from the same snapshot. Cancellation, abrupt transport closure, and handler
errors keep their existing behavior.