Enable SourceLink - #197
Closed
warrenbuckley wants to merge 2 commits into
Closed
warrenbuckley wants to merge 2 commits into
warrenbuckley wants to merge 2 commits into
Conversation
added 2 commits
May 2, 2019 15:58
…locally with PS1 build script seems it wants a very specific VS SDK installed even though VS17 & VS19 SDK tool is installed
Collaborator
Author
|
Ah boo 😢 no CI/CD build pipeline setup. Will have to wait until your back around @zpqrtbnk to see if you can help get me a build so I can confirm/clarify both packages are available to F11 into with SourceLink |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should add SourceLink @zpqrtbnk to the NuGet packages
However I was unable to build locally with PS1 build script, as it seems it wants a very specific VS SDK installed even though VS17 & VS19 SDK tool are installed 😕
Hopefully you have some CI pipeline with AppVeyor or AzureDevOps so I can download an artifact for this PR & test