Skip to content

[WIP] Add immutable number - #2

Open
rande wants to merge 2 commits into
moontoast:masterfrom
sonata-project:add_immutable_number
Open

[WIP] Add immutable number#2
rande wants to merge 2 commits into
moontoast:masterfrom
sonata-project:add_immutable_number

Conversation

@rande

@rande rande commented Jan 16, 2014

Copy link
Copy Markdown

No description provided.

@rande rande mentioned this pull request Jan 16, 2014
@rande

rande commented Jan 16, 2014

Copy link
Copy Markdown
Author

The immutable object is usefull if you want to display a price without changing the object itself.

$product->getUnitPrice()->mul($quantity = 4) ...

@rande

rande commented Jan 17, 2014

Copy link
Copy Markdown
Author

@ramsey Any comment on this PR ? I will add unit test on the class if you are agree on the change. By the way the changes are BC

@ramsey

ramsey commented Jan 17, 2014

Copy link
Copy Markdown
Contributor

I had to take time to review the changes, and it looked like there were a lot of them, but that's just because of all the whitespace changes.

Everything looks good. Please add the unit test, and I'll merge in the changes.

Thanks for contributing this!

@rande

rande commented Jan 20, 2014

Copy link
Copy Markdown
Author

Thanks for the feedback, I will do the unit test ASAP.

Thanks

@stefanotorresi

Copy link
Copy Markdown

@rande any update on this? I'd very much like this functionality. If you don't have the time let me know, I could pick this up.

peter279k pushed a commit to peter279k/math-3 that referenced this pull request May 22, 2018
php 7.0 unit tests fixes - correct octal numbers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants