[Certora] remove liquidate buffer#780
Closed
QGarchery wants to merge 1 commit into
Closed
Conversation
MathisGD
reviewed
Jul 21, 2026
Comment on lines
-62
to
-67
| // Hint for the prover to show that there is no bad debt realization. | ||
| assert newBorrowerCollateral != 0; | ||
| // Hint for the prover about the ratio used to close the position. | ||
| assert repaidShares * borrowerCollateral >= seizedAssets * borrowerShares; | ||
| // Prove that the ratio of shares of debt over collateral is smaller after the liquidation. | ||
| assert borrowerShares * newBorrowerCollateral >= newBorrowerShares * borrowerCollateral; |
Collaborator
There was a problem hiding this comment.
curious that we were doing this complex things if it was as simple as liquidateDecreasesBorrowExchangeRate
MathisGD
approved these changes
Jul 21, 2026
Contributor
Author
|
I confused the first step for a hint, so when I removed it becomes a redundant spec. The 2 steps are:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale is that it doesn't prove what it says it proves. What it actually proves is already proven in
liquidateDecreasesBorrowExchangeRate.See this run where the rule in liquidate buffer is simplified, so it looks more like
liquidateDecreasesBorrowExchangeRate