fix(pwa): claim CLI auth codes atomically in /cli/token#46
Merged
Conversation
The exchange did SELECT used -> UPDATE used=1 as separate statements. With a remote (network) libsql database, two concurrent exchanges can both pass the `used` check before either UPDATE lands, so one single-use code minted two API keys. Claim with a single conditional UPDATE ... WHERE used = 0 and reject when rowsAffected is 0. Adds integration tests for the single-use, PKCE, and expiry contracts (skip cleanly when apps/pwa deps aren't installed).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
apps/pwa/src/routes/cli.mjsexchanged one-time CLI auth codes with a check-then-act sequence:Against a remote libsql/Turso database (the production configuration uses
DATABASE_AUTH_TOKEN, i.e. DB over the network), two concurrent exchanges of the same code can both pass theused = 0check before eitherUPDATElands — minting two API keys from a single one-time code (TOCTOU race).Fix
Claim the code atomically and reject the exchange when the claim affects zero rows:
If
rowsAffected === 0, the code was already claimed (or doesn't exist) → 400. Correct on both localfile:DBs and remote Turso.Tests
New integration tests in
apps/pwa/test/cli-token.test.mjsexercise the real router:Note: with a local
file:DB the libsql client serializes statements, so the race window does not reproduce locally — the test asserts the guarantee (single-use), which holds in both deployments; the fix removes the window that exists with a remote DB.