test(tools): compare child cwd against its real path#47
Merged
Conversation
The passthrough test compared the child's process.cwd() (a resolved physical path) against the symlinked temp dir spelling, so the suite was red on macOS where os.tmpdir() is /var/... (a symlink to /private/var/...). Compare against realpathSync(cwd) — a no-op on platforms without the symlink.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
node --testfails on a fresh clone on macOS:os.tmpdir()on macOS returns/var/…, which is a symlink to/private/var/…. The child process reports its physical cwd, while the test compared against the symlinked path — so the suite was red out-of-the-box on macOS (Linux CI stayed green, hiding it).Fix
Compare against
realpathSync(cwd)instead. No-op on Linux, correct on macOS.Full suite after fix: 160/160 passing.