Add option to wrap lib in get() similar to @motiondeveloper/aefunctions - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In cases where functions in your library reference other values, like:
You will get a
ReferenceError: someNumber is not definedexpression error. If you attempt to reference viathis.someNumberyou won't get an expression error, but the value resolves toundefined.You've solved this in your aefunctions.jsx lib by wrapping all of your libs functions in a single
getFunctions()method. This PR adds similar functionality torollup-plugin-ae-jsxvia awrap: trueoption.Additionally, this PR will format your
.jsxwith TypeScript (seems to do a better job thanMagicString.trim().indent()) but given that project is written in JavaScript maybe it's not a great idea to introduce TypeScript just for this, haha!