v0.5.1: warn about repaired member names on table downloads - #172
Merged
Merged
Conversation
A table whose column names are clean but whose member labels carry a non-breaking space was repaired silently, since the metadata parser assumed the column name warning had already covered it. Give the member name repair its own context so every download path reports it once. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The NEWS section for the last release was still headed 0.4.5 although it shipped to CRAN as 0.5.0, so relabel it and open a 0.5.1 section for the member name warning. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The repair warnings and the no-data warning for vectors were wrapped to
getOption("width") when raised, which matched the window only by luck
and put line breaks in the middle of sentences in RStudio panes,
knitted documents and resized terminals. Each sentence now starts on
its own line and the window wraps the rest at its actual width.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Three vignettes had been excluded from the CRAN build via .Rbuildignore since 2018 and were only available on the pkgdown site. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Bring cran-comments.md up to date: the section describing the previous release was labelled 0.4.5 but that version was never published, it went out as 0.5.0. Add the 0.5.1 section. Fix three spelling mistakes in documentation found by spelling::spell_check_package(). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The finetuned warning joins the two closing sentences with a comma, so "this warning" is no longer capitalized. The test is network-only and skipped on CRAN, which is why the check passed with the stale text. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The chunk-level eval option keyed to COMPILE_VIG does not apply to inline `r ...` expressions in prose. Two of the restored vignettes had three such expressions, one calling search_cansim_cubes() over the network and two using variables only defined in unevaluated chunks, which failed the CRAN incoming pretest. They now fall back to fixed text when the vignettes are not being compiled. Also note the resubmission in cran-comments.md. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_cansim(),get_cansim_connection()with parquet and sqlite) reports it once, reads from cache stay silent, andoptions(cansim.suppress_repair_warnings=TRUE)silences it (Special characters in column names #169)Test plan
test-character_repair.Randtest-cache_info.Rpass with and withoutNOT_CRAN=trueNewfoundland<U+00A0>and Labrador, counts four repaired names, and is suppressed by the option🤖 Generated with Claude Code