Skip to content

Add submitted pings table - #3585

Open
jeddai wants to merge 21 commits into
mozilla:mainfrom
jeddai:add-submitted_pings-table
Open

Add submitted pings table#3585
jeddai wants to merge 21 commits into
mozilla:mainfrom
jeddai:add-submitted_pings-table

Conversation

@jeddai

@jeddai jeddai commented Aug 11, 2026

Copy link
Copy Markdown
Member

Re-opening from #3575

@jeddai
jeddai requested a review from badboy August 11, 2026 13:58
@jeddai jeddai self-assigned this Aug 11, 2026
@jeddai
jeddai requested a review from a team as a code owner August 11, 2026 13:58
@jeddai

jeddai commented Aug 12, 2026

Copy link
Copy Markdown
Member Author

Some changes:

  • Updated the PR to not require the time module for rusqlite by using Integers to store the dates
  • Added the mechanism to actually store the pings when they're submitted (still need to test this)

@badboy badboy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is starting to look pretty good (did a full review this time).
A few more things.

Right now getting those pings back from the outside is not implemented, but I assume that's gonna be done in a followup?

Comment thread glean-core/src/database/sqlite/schema.rs Outdated
Comment thread glean-core/src/database/sqlite.rs Outdated
Comment thread glean-core/src/database/sqlite.rs Outdated
Comment thread glean-core/src/database/sqlite.rs Outdated
Comment thread glean-core/src/database/sqlite.rs Outdated
Comment thread glean-core/src/database/sqlite.rs Outdated
Comment thread glean-core/src/database/sqlite.rs Outdated
Comment thread glean-core/src/database/sqlite.rs Outdated
Comment thread glean-core/src/metrics/ping.rs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants