Fix Bug 1615565: Use prettier to format frontend code - #1688
Merged
Conversation
abowler2
commented
Sep 26, 2020
| @@ -0,0 +1,19 @@ | |||
| # dependencies | |||
| /node_modules | |||
Collaborator
Author
There was a problem hiding this comment.
This file is a replication of the .gitignore file for the frontend as I was uncertain which files we might want to ignore, and felt this was a good representation.
Collaborator
|
I don't modify the JS code lately, but I'm in favor of using an auto-formatter. The hanges look good for me :-) I can take a look later when the Makefile/Travis part is done, or help if there's any problem with that part. |
Collaborator
|
I like! Let's add it to CI and add some make commands. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses the Prettier documentation along with the previous work from @adngdb to add, configure, and run Prettier to format the frontend code.
Pending feedback and review on this I can add it to the CI as well as create a
makecommand to make it easier to enforce the changes.