Automated releases - #4393
Conversation
|
@eemeli, for the SBOM step, since workflows cannot trigger workflows, I can't use |
That's not really true. You need to run the workflow with a PAT, and that's a secret in the repository, not the org. |
| pull-requests: read | ||
| steps: | ||
| - name: Clone repository | ||
| uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 |
There was a problem hiding this comment.
This is already behind the latest version
| name: Automated Release | ||
| on: | ||
| schedule: | ||
| - cron: "0 23 * * *" |
There was a problem hiding this comment.
Can we run this a bit earlier?
- All engineers are EU based, this is between dates.
- This changes with time zones (1 or 2 hours difference).
I think we could safely run this at 20 or 21 UTC.
There was a problem hiding this comment.
I actually recommended 23:00 UTC explicitly, as it's a time that'll most certainly associate the calver date with the day when the deployment actually happened.
The idea is that this'll be looking backwards to find and tag the last prod release made on that day, and that if necessary, we'll amend the release notes on the following day.
| exit 1 | ||
| fi | ||
|
|
||
| COMMIT_EXISTS=$(git tag --points-at "$SHA" | grep '^v202' || true) |
There was a problem hiding this comment.
| COMMIT_EXISTS=$(git tag --points-at "$SHA" | grep '^v202' || true) | |
| COMMIT_EXISTS=$(git tag --points-at "$SHA" | grep -E '^v[0-9]{4}\.[0-9]{2}\.[0-9]{2}$' || true) |
Maybe avoid planned obsolesce?
There was a problem hiding this comment.
This too is doing a thing I asked for in #2402 (comment)
I'm fine either way; if we're still using this in three years, we can also update the condition then and keep it simple for now.
The variable name here is wrong though; it should be TAG_EXISTS.
The change you already have for the action ought to be sufficient. See for example the corresponding moz-l10n action, and the SBOM it added to the latest release. |
Rather, I am referring to a different issue regarding running the sbom workflow immediately conditioned on a release. We cannot use GITHUB_TOKENS, I was thinking using PAT tokens instead but the created release will be automatically authored by Matjaz for example. |
As discussed in #2402, we want to be able to have an automated release structure so contributors and non-contributors can better keep track of our work. This is not to function as fully fledged release notes - rather it is a way of tracking work deployed onto the production Pontoon instance on a daily basis. See this comment for more information.