Add -fno-cxx-modules to clang's known -Xclang flags - #2717
Open
badumbatish wants to merge 1 commit into
Open
Conversation
Collaborator
|
please add a test |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2717 +/- ##
==========================================
- Coverage 74.41% 72.92% -1.49%
==========================================
Files 70 72 +2
Lines 39211 37285 -1926
==========================================
- Hits 29177 27190 -1987
- Misses 10034 10095 +61 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merging this PR will not alter performance
Comparing Footnotes
|
Downstream Bazel's C++ toolchain passes `-Xclang -fno-cxx-modules` in its compiler sanity checks. Since -fno-cxx-modules wasn't in sccache's known flag list, the xclang argument parser in gcc.rs treated it as an UnknownFlag and bailed with CannotCache.
badumbatish
force-pushed
the
no_cxx_module
branch
from
August 11, 2026 08:23
71cfd42 to
4d17147
Compare
Author
apologies for the late actions, please see the latest PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downstream Bazel's C++ toolchain passes
-Xclang -fno-cxx-modulesin its compiler sanity checks. Since -fno-cxx-modules wasn't in sccache's known flag list, the xclang argument parser in gcc.rs treated it as an UnknownFlag and bailed with CannotCache.