Repository navigation
chore(deps): Keep risky majors out of the NuGet group, move Testcontainers together - #132
Merged
Merged
Conversation
…iners together The all-nuget group (#128) broke the build in three ways: - It raised Testcontainers to 4.15.0 but left Testcontainers.MongoDb and .Redis on 4.7.0. The 4.7 modules can't run on the 4.15 core (MissingMethodException in every Mongo integration test). - It jumped Radzen.Blazor four majors (7.3.2 -> 11.4.1). - It jumped MessagePack to 3.x, although it is pinned only to force a patched transitive version and Aspire's StreamJsonRpc is built on 2.5.x. Dependabot now skips major versions of Radzen.Blazor and MessagePack, and puts every Testcontainers package in its own group so they always move together. Testcontainers and its modules move to 4.15.0 here, with the wait strategy renamed to UntilInternalTcpPortIsAvailable (the old UntilPortIsAvailable is gone in 4.15). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The dependency alignment, API migration, and Dependabot rules are internally consistent and valid.
Review effort: Balanced
Findings: None
What changed in this PR
Aligns Testcontainers dependencies and prevents risky major upgrades from entering grouped Dependabot PRs.
Changes:
- Aligns all Testcontainers packages at 4.15.0.
- Migrates to the renamed internal-port wait API.
- Separates Testcontainers updates and excludes risky majors.
| File | Description |
|---|---|
.github/dependabot.yml |
Adds exclusions and a Testcontainers group. |
Directory.Packages.props |
Aligns Testcontainers package versions. |
tests/IssueTracker.PlugIns.Tests.Integration/IssueTrackerTestFactory.cs |
Updates the wait-strategy API call. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
=======================================
Coverage 85.59% 85.59%
=======================================
Files 77 77
Lines 1562 1562
Branches 143 143
=======================================
Hits 1337 1337
Misses 180 180
Partials 45 45 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The recreated Dependabot group PR #128 fails, and would be risky even once it builds:
Testcontainers.MongoDb/.Redisleft on 4.7.0. Build fails (UntilPortIsAvailableremoved), and after that all 54 Mongo integration tests fail withMissingMethodException.Radzen.createDataGridJS call). Component and theme changes need a manual UI check.What
.github/dependabot.yml(nuget):ignoresemver-major updates ofRadzen.BlazorandMessagePack. Minor and patch updates still come through.testcontainersgroup (Testcontainers*) ahead ofall-nuget, so the core and its modules always move together.Testcontainers aligned now:
Testcontainers,.MongoDband.Redisgo to 4.15.0.IssueTrackerTestFactoryswitches toUntilInternalTcpPortIsAvailable, the 4.15 name for the same wait.Validation
dotnet build -c Release: 0 errors.yamllintclean ondependabot.yml.After merge
@dependabot recreateon #128. It should come back without the Radzen and MessagePack majors or Testcontainers. The Radzen 11 upgrade gets its own PR.🤖 Generated with Claude Code