Keep the dgemma request's redirects manual - #126
Merged
Merged
Conversation
The Workers runtime has no redirect "error" mode and throws on the option, so every request to the image-capable service failed before it was sent and the route answered dgemma_unavailable. Redirects are now "manual": a 3xx comes back as a response and is answered as an outage, which is what the runtime's own message recommends. A test pins the option and the mapping. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 7 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
redirect: "error". The Workers runtime has no such mode and throws aTypeErroron the option, so in production everydgemmarequest failed before leaving the Worker and the route answered503 dgemma_unavailable. The unit tests run under bun, which accepts the option, so they did not catch it.redirect: "manual": a 3xx comes back as a response and is answered as an outage, which is what the runtime's own error message recommends. Nothing is ever followed.Checks
npx tsc --noEmitclean;test/dgemma.test.ts8 pass.🤖 Generated with Claude Code