Conversation
added 30 commits
November 4, 2017 18:21
accidentaly deleted
# Conflicts: # R/NNI.R # R/SPR.R # man/NNI.Rd # tests/testthat/test-tree-rearranged-numbering.R
# Conflicts: # R/TBR.R # R/helper_functions.R
Allows simultaneous scoring
added 24 commits
January 31, 2018 11:55
(properly)
ms609
added a commit
that referenced
this pull request
Jun 18, 2026
… bug Post-fix gap-panel re-measurement (diag_gap_panel_postfix.R, thorough, 60s, 3 seeds): Wortley 479 (-1), Zanol/Zhu/Giles +0 -- full search now reaches the MPT across the hard panel. Overturns the Phase 1-3/Challenge-2 'landscape/escape-bound floor, not frugality-bound' conclusion: the +1/+3 was substantially the union-of-finals insertion-cost bug (commits 2b299e4, 93071ca). Candidates-per-improvement reversed (Vinther 6.3x worse -> 0.44x). Closes the core-deficit (#26) and drift-for-+1 (#25, now moot) threads; race-to-target reached, leaving only the Hamilton wall-clock ratio open (#22). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ms609
added a commit
that referenced
this pull request
Jul 3, 2026
… + Δ-probe expand_and_reinsert (T-266, 2026-03-27) used the union-of-finals fitch_indirect_length_bounded approximation that the June directional fix (#26/#27) replaced everywhere else — it was MISSED. Port it to the exact edge_set scorer, mirroring ts_wagner.cpp:487: - per-tip compute_insertion_edge_sets (prelim is current via wagner_incremental_rescore) + fitch_indirect_length_cached per edge. Also a gated, non-perturbing -DTS_SCOREAPPROX_PROBE oracle that tallied Δ = exact_cost(E_bounded) − min_E exact_cost(E) per placement. On Zanol (forced pruneReinsertCycles): bounded chose strictly-worse edges in ~62% of placements, mean ~6 steps, ~48% greedy-regret SHARE. After the port the probe reports Δ=0 at every placement (production == exact argmin). NOTE: this is greedy-regret SHARE, not realizable wall-clock — prune_reinsert auto-enables ONLY at nTip>=120 (`large` preset); NO mission dataset reaches 120t (max=88). So this path runs on zero default mission searches. Land + time-matched A/B (NNI-polish `large` preset, ≥120t) is COMPOSITION-gated (#40). Worktree-only; NOT for cpp-search until composition. Tests: prune-reinsert 44/0, drift 22/0, ratchet 17/0, tbr 28/0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves efficiency by dispensing with fourth pass