Add fast-forward speed control and IPS32/BPS support - #32
Draft
Nicktendonick wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
GBA recomp projects need a launcher-level way to apply community translation and modification patches while continuing to verify the user's clean source ROM. BPS and IPS32 cover common patches that classic IPS alone cannot represent, and the Assist speed setting lets a host expose a controlled fast-forward range without adding game-specific UI code.
The existing configurable Assist bindings already landed upstream in a newer generalized form, so that redundant commit is intentionally not part of this PR.
Validation
recomp-uilauncher from currentmasterwith the SDL2 backendAll seven tests passed on Windows with MinGW/Ninja.
Notes for review