Make Dark Mode Automatic#178
Conversation
35aa9c1 to
6eea53e
Compare
|
Thanks for contributing this! Would it be possible to narrow the scope down to just what's necessary for automatic dark mode? So we'd revert the changes to I'd also like to keep the third-party code in the "How to Make Your Code Reviewer Fall in Love with You" also contains some tips about how to make the code contribution process work smoothly. |
|
It might be possible to use I'm going to need to make changes to the Prism code anyway; one version is minified and the other is not - I may as well retain the upgrade in a new commit. I won't revert the emberstack change - that fixes CI breakage. As long as you don't squash commits when you merge the PR each of these should be an atomic change. |
Can you pull this into a separate PR and make that change first? Keep in mind, this PR will be squashed before merging, so it needs to merge cleanly with that in mind. |
6eea53e to
a5eae03
Compare
|
Requested changes made; Prism still updated because I'd have had to dig out an older version to make both consistent.
Why squash a PR with atomic commits? I could understand if the commits were:
I rebased and force pushed any CI/CD catches, so squashing this PR before I split it for you seems like it's being done for opaque reasons and has has added an additional 200% overhead to a simple change. |
a5eae03 to
3776926
Compare
The old state was one minified and one 'development'; for consistency and ease of development / tinkering they're all 'development' flavours now, but it we need to save a few K per request maybe adding a CSS minifying step to the release-generating CI is the best solution. It's beyond the scope of this PR regardless! |
I understand that you have your own workflow that's comfortable for you. I maintain several open-source projects, and I do it just as a hobby, so I arrange workflows that optimize for my efficiency as the maintainer. I appreciate and value contributions like yours, but it's a nontrivial increase in my time to adapt the PR review workflow for each individual contributor. All my repos are exclusively squash and merge because that yields a consistent result regardless of the contributor's commit hygiene. Force pushing actually makes the reviews harder because I can't compare the current version to the last version I reviewed, so I've now disabled them for this repo. |
mtlynch
left a comment
There was a problem hiding this comment.
Thanks for splitting it up! This is much easier to review.
Use `@media (prefers-color-scheme:` to determine which CSS to load based on the browser's preference. This change removes the manual 'Dark Mode' toggle.
Use
@media (prefers-color-scheme:to determine which CSS to load based on the browser's preference.This change consolidates all CSS into
style.cssand removes the manual 'Dark Mode' toggle.Also grabbed 'development' flavours of both Prism CSS themes to make them consistent and updated Prism to 1.29.
Closes #175