[base] Change the order of class names merged in useSlotProps - #33383
Merged
Conversation
Contributor
|
Great!!! |
mnajdova
approved these changes
Jul 5, 2022
mnajdova
left a comment
Member
There was a problem hiding this comment.
Looks great. Please add a comment in mergeSlotProps above the joinedClasses declaration a comment explaining why this order is important, so that we can have a context in the future if we need to add more thing there.
Member
Author
|
Done. I just hope we won't see another popular styling library require the opposite order to work correctly. MUI Base is supposed to work with any styling solution and I'm not very happy about such a leaky abstraction. |
Contributor
|
Hi @michaldudak, |
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets the order of classes returned from useSlotProps to be internal-first, external-last. This was discussed in #33205 (comment)
cc @garronej