Conversation
Co-authored-by: muke1908 <20297989+muke1908@users.noreply.github.com>
|
Copilot
AI
changed the title
[WIP] Audit and minimize avoidable metadata leakage
Minimize avoidable chat and signaling metadata disclosure
Sep 11, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
A moderate privacy issue remains because relay-visible IDs use Math.random() instead of a CSPRNG.
Review effort: Lite
Findings: None
What changed in this PR
This PR reduces chat and signaling metadata exposure while preserving legacy APIs and documenting remaining E2EE metadata visibility.
Changes:
- Adds count-only participant presence with legacy compatibility.
- Minimizes socket payloads and identifier-bearing diagnostics.
- Adds contract tests and privacy documentation.
| File | Description |
|---|---|
service/src/socket/socket.ts |
Minimizes socket payload fields. |
service/src/socket/socket.test.ts |
Tests payload and logging contracts. |
service/src/sdk.ts |
Adds count-based presence checks. |
service/src/sdk.test.ts |
Tests count usage and privacy logging. |
service/src/public/types.ts |
Exposes participant-count API. |
service/src/api/messages.ts |
Implements count-only requests and fallback. |
service/src/api/messages.test.ts |
Tests count and compatibility behavior. |
service/README.md |
Documents SDK privacy behavior. |
README.md |
Documents metadata limitations. |
client/src/context/ChatContext.tsx |
Uses count-only presence checks. |
backend/socket.io/listeners.ts |
Removes room identifiers from diagnostics. |
backend/socket.io/listeners.test.ts |
Tests relay and logging contracts. |
backend/README.md |
Adds metadata inventory and privacy guidance. |
backend/api/messaging/index.ts |
Supports count-only responses. |
backend/api/messaging/index.test.ts |
Tests count and compatibility behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Reduce plaintext metadata exposed by chat and signaling without breaking existing payload contracts. Document what remains visible despite E2EE.
getParticipantCount()andcountOnly=true; migrate UI presence checks and SDK call preconditions. Preserve the legacy identity-list API and accept older servers’ list responses.version,strategy,data), preserving opaque strategy data. Remove identifiers from join/channel diagnostics.