Fix O2+ charge-exchange temperature exponent in air11 Park mechanism - #320
Open
MaXXe4th wants to merge 2 commits into
Open
Fix O2+ charge-exchange temperature exponent in air11 Park mechanism#320MaXXe4th wants to merge 2 commits into
MaXXe4th wants to merge 2 commits into
Conversation
Collaborator
|
Definitely looks like a bug to me. Thanks for the PR! |
Collaborator
|
Hi @MaXXe4th, thanks for reporting this. I was checking; there are 2 versions of the same paper (Review of Chemical-Kinetic Problems of Future NASA Missions, I: Earth Entries): one with a positive value, one with a negative value. I see a negative value reported in other codes, and I agree that the modification would be consistent with the Mars mechanism. Can you please leave the legacy file unchanged, such that if someone has tests built around the old version of the mechanism can still perform them? Thanks, Michele |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct the temperature exponent for the charge-exchange reaction
in
air11_Park.xmland 'air11_Park_legacy.xml'.Park (1993), Table 2, gives:
The mechanism currently uses
n = +0.09.The corresponding reaction in
Mars_19_Park.xmlalready usesn = -0.09.air11_Park_legacy.xmlcontains the same value and is also changed to provide correct results for legacy users.