Skip to content

Lightning section - #17

Merged
abhiShandy merged 3 commits into
masterfrom
lnd
Sep 18, 2020
Merged

Lightning section#17
abhiShandy merged 3 commits into
masterfrom
lnd

Conversation

@abhiShandy

@abhiShandy abhiShandy commented Sep 17, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Checklist

  • tested locally using Vuepress
  • mentioned related issue

#3

@abhiShandy

abhiShandy commented Sep 18, 2020

Copy link
Copy Markdown
Collaborator Author

@davterra look at this

@davterra

davterra commented Sep 18, 2020

Copy link
Copy Markdown
Contributor

Will do

davterra
davterra suggested changes Sep 18, 2020
View reviewed changes

@davterra davterra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. One suggestion: We have the restore.md that refers to a channel.backup but I don't think we have anything written about how to download a local channel.backup or where to find it in the myNode file structure if you don't download it. It could either be worked into the restore.md chapter, or maybe it needs it's own lnd-channel-backup.md chapter. I could do either pretty quickly if you have other priorities ATM.

Comment thread docs/lightning/lnd-alias.md Outdated
Comment thread docs/lightning/lnd-alias.md Outdated
abhiShandy and others added 2 commits September 18, 2020 13:28
@abhiShandy @davterra
Update docs/lightning/lnd-alias.md
bb9ea3b 
Co-authored-by: davterra <davterra44@gmail.com>
@abhiShandy @davterra
Update docs/lightning/lnd-alias.md
2f887c0 
Co-authored-by: davterra <davterra44@gmail.com>
@abhiShandy

abhiShandy commented Sep 18, 2020

Copy link
Copy Markdown
Collaborator Author

Good stuff. One suggestion: We have the restore.md that refers to a channel.backup but I don't think we have anything written about how to download a local channel.backup or where to find it in the myNode file structure if you don't download it. It could either be worked into the restore.md chapter, or maybe it needs it's own lnd-channel-backup.md chapter. I could do either pretty quickly if you have other priorities ATM.

I won't work on this ATM. Let me merge this PR and then you can take it forward with another PR.

@abhiShandy
abhiShandy merged commit 18beeb3 into master Sep 18, 2020
@abhiShandy
abhiShandy deleted the lnd branch September 18, 2020 22:48
@abhiShandy abhiShandy added this to the 1.0.0 milestone Sep 24, 2020
mynode-dev pushed a commit that referenced this pull request Aug 24, 2026
@abhiShandy @davterra
Lightning section (#17)
ab0db24 
* cleanup lnd pages, add restore page

* Update docs/lightning/lnd-alias.md

Co-authored-by: davterra <davterra44@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@davterra davterra davterra requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@abhiShandy @davterra