First draft of ThunderHub chapter for myNodeDocs - #20
Conversation
Fix incorrect image Add image Add info about thunderhub port and file location
davterra
left a comment
There was a problem hiding this comment.
@abhiShandy
I applied your suggestions and pushed a fresh version.
Let me know of any more changes that you think are needed.
|
Looks good to me |
|
I pulled this branch to visualize it locally. I have few suggestions:
|
Yeah I considered centering the thumbnail and decided to wait for your opinion. I'll do that... I like the "specs" idea. But then we should do that for each app. |
davterra
left a comment
There was a problem hiding this comment.
@abhiShandy I applied your suggested changes with one exception: In the new "Specs" section at the end, I left out the version #. It seems to me that if we include the version number for every app on its respective page that we'll soon have a full-time job just keeping them all current, as apps get upgraded and Taylor applies them in myNode.
Let me know what you think. I'm going to now start on the RTL page, which is currently not too bad in Taylor's docs, but it needs updating. Let me know if you have higher priorities.
After RTL I thought I'd just start working my way through the "Help Wanted" tags in the Issues.
|
I agree. We should remove the version from Specs. Let's remember to have this subsection for every app. I'll take a final look and merge it. You can start working on RTL and other apps. |
* First draft of ThunderHub chapter for myNodeDocs * Fix incorrect image * Update docs/lightning/thunderhub.md * minor edits * Center thumbnail image and add "specs" section at the end. * reformat few lines, add tile image and cleanup Co-authored-by: abhishandy <abhishek.sandy@gmail.com>
Ok, first draft of ThunderHub chapter.
Please review & critique for content & length.