SVS-PS v3#22
Conversation
e685b4c to
ce5a945
Compare
I'm not against the idea in principle. However, I'm not sure it makes sense to use SequenceNumNameComponent in the name, but then use a custom SeqNo TLV inside MappingData. It may not be wrong per se, but I don't love the mismatch/inconsistency. That said, the sequence number change goes beyond what was approved at today's call, so I'm not comfortable merging this without the group's approval. |
|
The spec is written according to what @matianxing1992 implemented in this PR:
I don’t see anything wrong so I just followed his lead. |
|
Yeah but what about the definition of MappingEntry/SeqNo? Should SeqNo become an alias of SequenceNumNameComponent as well? More importantly, the discussion and decision at today's call centered around adding the bootstrap time component to the name. I didn't realize the sequence number encoding was also different (and probably others didn't either). And we didn't discuss changing the @matianxing1992 @tianyuan129 What do you think? |
Although, on second thought, the same can be said for SeqNo in StateVectorEntry in the base SVS protocol... And I'm guessing we do not want to make breaking changes to the base SVSv3. So I suppose I'm fine either way. Just want to make sure the others are on board (and know about this additional change). |
|
I realized that the switch to SequenceNumNameComponent is a recommendation in SVS v3 protocol:
The same line in SVS v2 was:
Hence, the change is already part of SVS v3 and not a sudden choice by C++ library developer. |
fixes #20
The general structure has been approved in 2026-07-17 NFD call.
However, please review the adoption of NDN Naming Convention rev3 in the sequence number component.
In previous version, it was using GenericNameComponent with NonNegativeInteger in the TLV-VALUE.
In this PR, it has been changed to SequenceNumNameComponent.