Conversation
skliper
suggested changes
Dec 14, 2020
skliper
left a comment
Contributor
There was a problem hiding this comment.
Should the client sockets get closed?
zanzaben
force-pushed
the
fix377_Select_Functional_Tests
branch
from
December 15, 2020 15:19
d0f3120 to
b18e9d3
Compare
Contributor
|
CCB 2020-12-16 APPROVED
|
zanzaben
force-pushed
the
fix377_Select_Functional_Tests
branch
from
December 16, 2020 17:32
d15206b to
1b85700
Compare
Contributor
|
@zanzaben - could you add a more descriptive commit message on the last two commits? The current text isn't sufficient to describe the change. Let me know if suggestions would help. |
zanzaben
force-pushed
the
fix377_Select_Functional_Tests
branch
from
December 16, 2020 18:36
1b85700 to
87b8915
Compare
zanzaben
force-pushed
the
fix377_Select_Functional_Tests
branch
from
December 16, 2020 21:01
87b8915 to
d5727f9
Compare
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Dec 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fixes #377
Added new functional tests for the the select and select multiple functions.
Testing performed
Ran the new tests.
Expected behavior changes
None
System(s) tested on
Ubuntu 20.04
Contributor Info - All information REQUIRED for consideration of pull request
Alex Campbell GSFC