DRY up duplicated count_queries test helper - #11884
Merged
nbudin merged 1 commit intoAug 6, 2026
Merged
Conversation
Six test files had grown byte-identical copies of this N+1 query-count helper. Defined it once on ActiveSupport::TestCase in test_helper.rb instead, matching the existing execute_graphql_query helper there. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The N+1 query regression tests added across the last few PRs (#11880, #11882, #11883) each defined their own private
count_queries(pattern) { ... }helper -- byte-identical in all six files. Moved it ontoActiveSupport::TestCaseintest_helper.rb, next to the existingexecute_graphql_queryhelper that's set up the same way, so every test file gets it for free.test/services/event_signup_service_test.rb's other private helpers (bucket_id_for,create_other_signup) are untouched.Test plan
🤖 Generated with Claude Code