parse: flex: parse flex-shrink before flex-basis in the shorthand - #40
Open
metan-ucw wants to merge 1 commit into
Open
parse: flex: parse flex-shrink before flex-basis in the shorthand#40metan-ucw wants to merge 1 commit into
metan-ucw wants to merge 1 commit into
Conversation
The flex shorthand loop tried the longhands in the order grow, basis, shrink. Because the flex-basis <length> parser also accepts a bare 0, `flex: 0 0 600px` mis-assigned the second 0 to flex-basis and was then left with 600px to parse as flex-shrink (a number), which fails and invalidates the whole declaration. The two <number> values are flex-grow and flex-shrink, so try shrink before basis; a unit-bearing length or percentage still falls through to basis. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Cyril Hrubis <metan@ucw.cz>
metan-ucw
force-pushed
the
fix-flex-parse
branch
from
August 16, 2026 20:32
563154b to
65f6884
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flex shorthand loop tried the longhands in the order grow, basis, shrink. Because the flex-basis parser also accepts a bare 0,
flex: 0 0 600pxmis-assigned the second 0 to flex-basis and was then left with 600px to parse as flex-shrink (a ), which fails and invalidates the whole declaration.The two values are flex-grow and flex-shrink, so try shrink before basis; a unit-bearing length or percentage still falls through to basis.