MimePart: fixed not escaped header before encoded into utf-8 - #102
Merged
Conversation
Daaarkling
force-pushed
the
fix-escaping
branch
from
October 10, 2024 10:26
0f3a919 to
4b6f672
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
December 30, 2025 00:48
af1d65e to
93bc1c9
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
February 10, 2026 02:48
5aeaf1e to
82f31ef
Compare
dg
force-pushed
the
master
branch
5 times, most recently
from
February 24, 2026 16:12
e5578f0 to
e220d35
Compare
dg
force-pushed
the
master
branch
10 times, most recently
from
March 31, 2026 17:42
d266800 to
189277a
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
April 23, 2026 21:06
d356e6e to
211bd8c
Compare
dg
pushed a commit
that referenced
this pull request
Apr 23, 2026
…ncoding (#102) When a name in From/To/Cc contained characters outside RFC 2822 atext (e.g. comma or quote in a UTF-8 name), it was base64-encoded as-is. After the recipient decoded it, the raw special chars reappeared in the phrase and could be misparsed (a comma would split one address into two). Wrap such phrases in quoted-string before encoding, so the decoded form is a valid quoted phrase. Applies only to the phrase part of address headers, not to Content-Disposition filename values.
Contributor
|
@Daaarkling I'd welcome your eyes on #107, which narrows the predicate this PR added. The escape introduced here fires on any character outside RFC 2822 #107 keeps your protection but limits it to characters that could restructure the address list for a receiver that re-parses the decoded phrase: Two things you're better placed to judge than I am:
Thanks |
dg
pushed a commit
that referenced
this pull request
Aug 18, 2026
…ed (#107) whenever it contained anything outside RFC 2822 atext. Every accented letter is outside atext, so every non-ASCII name was quoted, and because the quotes land inside the base64 payload, clients showed them as part of the name: "Objednávky domena.cz" instead of Objednávky domena.cz. Per RFC 2047 §6.2 an encoded-word is decoded only after the field is parsed, so quotes there are not syntax; they only guard against a receiver that decodes first and re-parses the result (the Gmail failure behind #102). The encoded path therefore quotes only names holding a character such a receiver could turn into another address (,;:<>@"\); diacritics and dots are encoded bare. The literal path keeps the atext test, where the quotes are real RFC 5322 delimiters.
dg
pushed a commit
that referenced
this pull request
Aug 18, 2026
…ed (#107) whenever it contained anything outside RFC 2822 atext. Every accented letter is outside atext, so every non-ASCII name was quoted, and because the quotes land inside the base64 payload, clients showed them as part of the name: "Objednávky domena.cz" instead of Objednávky domena.cz. Per RFC 2047 §6.2 an encoded-word is decoded only after the field is parsed, so quotes there are not syntax; they only guard against a receiver that decodes first and re-parses the result (the Gmail failure behind #102). The encoded path therefore quotes only names holding a character such a receiver could turn into another address (,;:<>@"\); diacritics and dots are encoded bare. The literal path keeps the atext test, where the quotes are real RFC 5322 delimiters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Headers containing special characters such as Czech characters also need to be escaped before converting to utf-8.
Example header
From: Kdo uteče, obědvá <doe@example.com>When google processes the email, it misparses the comma and because of that the DKIM signature verification fails and the email is rejected.