Refactor test, implement dual banner fix - #456
Merged
qduk merged 2 commits intoFeb 7, 2024
Merged
Conversation
housepbass
requested review from
abates,
itdependsnetworks,
jeffkala and
qduk
as code owners
February 7, 2024 14:22
itdependsnetworks
approved these changes
Feb 7, 2024
qduk
approved these changes
Feb 7, 2024
itdependsnetworks
added a commit
that referenced
this pull request
Feb 9, 2024
* dual banner test case single banner feature search * Refactor test, implement dual banner fix (#456) * Refactor test, implement dual banner fix * Add tests for multiple banners --------- Co-authored-by: Anthony House <anthony.house@networktocode.com> --------- Co-authored-by: Jeff Kala <jeff.l.kala@gmail.com> Co-authored-by: housepbass <80693460+housepbass@users.noreply.github.com> Co-authored-by: Anthony House <anthony.house@networktocode.com>
michalis1
pushed a commit
to michalis1/netutils
that referenced
this pull request
Feb 2, 2026
* dual banner test case single banner feature search * Refactor test, implement dual banner fix (networktocode#456) * Refactor test, implement dual banner fix * Add tests for multiple banners --------- Co-authored-by: Anthony House <anthony.house@networktocode.com> --------- Co-authored-by: Jeff Kala <jeff.l.kala@gmail.com> Co-authored-by: housepbass <80693460+housepbass@users.noreply.github.com> Co-authored-by: Anthony House <anthony.house@networktocode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement handling for multiple banner configurations. ie a configuration file containing both
banner execandbanner motd