Skip to content

Add Skip inaccessible SharePoint Online sites option - #1254

Open
TheNewCat777 wants to merge 3 commits into
devfrom
fix/auditor-10.9-sharepointonline-skip-inaccessible-sites
Open

Add Skip inaccessible SharePoint Online sites option#1254
TheNewCat777 wants to merge 3 commits into
devfrom
fix/auditor-10.9-sharepointonline-skip-inaccessible-sites

Conversation

@TheNewCat777

Copy link
Copy Markdown
Contributor

Summary

  • Adds new Skip inaccessible SharePoint Online sites data source option: when enabled, Netwrix Auditor skips sites inaccessible to the data collecting account and
    continues collection for the remaining sites

  • Restructures the page to match the standard pattern (SQL Server, File Servers): data source settings table moved under the top-level # SharePoint Online heading,

  • Adds new Skip inaccessible SharePoint Online sites data source option: when enabled, Netwrix Auditor skips sites inaccessible to the data collecting account and
    continues collection for the remaining sites

  • Restructures the page to match the standard pattern (SQL Server, File Servers): data source settings table moved under the top-level # SharePoint Online heading,
    item procedure kept as a subsection below

  • Fixes formatting: converts inline NOTE to admonition block, moves government tenant note into Step 1 bullets, fixes Application secret indentation

🤖 Generated with Claude Code

TheNewCat777 and others added 2 commits July 24, 2026 15:43
…on and restructure data source settings

Moves data source settings table to the top-level section (matching the SQL Server/File Servers pattern) and adds the new Skip inaccessible SharePoint Online sites option.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…n article

Convert inline NOTE to admonition, move government tenant note into Step 1 bullets, and fix Application secret indentation.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@TheNewCat777
TheNewCat777 requested a review from a team as a code owner July 24, 2026 15:04
@github-actions

Copy link
Copy Markdown
Contributor

Documentation PR Review

Editorial Review

docs/auditor/10.9/admin/monitoringplans/sharepointonline/overview.md

  • Structure — Line 21: The relocated data source settings block now sits between the prerequisites note and the ## How to Add Office365 Item heading with no heading of its own. A reader scanning the page hits a large settings table with no section label to orient them. The move itself is logical (data source settings are configured before you add items, so placing them ahead of the "Add item" procedure reflects the real workflow), but the block reads as orphaned content. Suggested fix: add a heading above line 21, e.g. ## Configure SharePoint Online Data Source Settings.

  • Completeness — Line 21: "To configure SharePoint Online data source settings, complete the following fields:" doesn't tell the reader where these fields appear or how they reached this screen. As Step 4 the table inherited that context from the preceding steps; standing at the top of the document it has none. Suggested fix: add a lead-in sentence that names the location, e.g. "When you add SharePoint Online as a data source to a monitoring plan, the data source properties dialog displays the following fields:".

  • Clarity — Line 28: The "Collect data for state-in-time reports" cell packs an entire snapshot-import sub-procedure (Manage → select snapshots → move with the arrow button → OK, plus a role requirement) into a single table cell. This was already dense, but it's now more prominent at the top of the page. Suggested fix: keep a one-sentence description in the cell and move the snapshot-import steps into a short numbered procedure below the table.

Summary

3 editorial suggestions across 1 file. The formatting changes in this PR (converting the basic-authentication NOTE: to a :::note admonition, normalizing the Application ID / Application secret list, folding the government-tenant instruction into the Step 1 bullet list, and fixing the trailing-space link text) are all clean improvements. Vale and Dale issues are auto-fixed separately.


What to do next:

Comment @claude on this PR followed by your instructions to get help:

  • @claude fix all issues — fix all editorial issues
  • @claude help improve the flow of this document — get writing assistance
  • @claude explain the voice issues — understand why something was flagged

You can ask Claude anything about the review or about Netwrix writing standards.

Automated fixes are only available for branches in this repository, not forks.

@github-actions

Copy link
Copy Markdown
Contributor

Auto-Fix Summary

10 issues fixed, 4 skipped across 1 files

Category Fixes
Removed filler 1
Substitutions 2
FollowTheStepsTo (rewrite) 1
FormalHedging (rewrite) 1
OxfordComma (rewrite) 1
Dale: idioms 1
Dale: passive-voice 3
Skipped (needs manual review) Reason

| docs/auditor/10.9/admin/monitoringplans/sharepointonline/overview.md:28 — Dale: passive-voice | 'you must be assigned the Global administrator or the Global reviewer role' — rewording to active voice risks altering the required-role meaning in a dense table cell. |
| docs/auditor/10.9/admin/monitoringplans/sharepointonline/overview.md:58 — Dale: passive-voice | 'Tenant name will be filled in automatically' describes UI-driven behavior; active-voice rewrite would need an unstated subject and risks changing meaning. |
| docs/auditor/10.9/admin/monitoringplans/sharepointonline/overview.md:78 — Dale: passive-voice | 'Selected, Office 365 organization will be accessed on behalf of the user you specify.' — sentence fragment with unclear subject; ambiguous how to rewrite without changing meaning. |
| docs/auditor/10.9/admin/monitoringplans/sharepointonline/overview.md:88 — Dale: passive-voice | 'Selected, Office 365 organization will be accessed using the Microsoft Entra ID app you prepared.' — sentence fragment with unclear subject; ambiguous how to rewrite without changing meaning. |

Ask @claude on this PR if you'd like an explanation of any fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants