fix(pgvector): make doc deletion query faster - #289
Merged
Conversation
kyteinsky
force-pushed
the
fix/long-deletes
branch
2 times, most recently
from
March 20, 2026 13:30
02b8435 to
f03c10a
Compare
kyteinsky
commented
Mar 20, 2026
kyteinsky
marked this pull request as draft
March 20, 2026 13:31
kyteinsky
force-pushed
the
fix/long-deletes
branch
from
May 20, 2026 13:37
f03c10a to
37bfcc6
Compare
Contributor
Author
|
verified again the index actually does improve things: after: the difference in time to pay attention to is index can be manually created like so: |
kyteinsky
marked this pull request as ready for review
May 21, 2026 10:01
index the source_id column in the access_list table use a defined name for the source_id index Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
…ir fails also sort repair filenames Signed-off-by: kyteinsky <kyteinsky@gmail.com>
Signed-off-by: kyteinsky <kyteinsky@gmail.com>
kyteinsky
force-pushed
the
fix/long-deletes
branch
3 times, most recently
from
May 25, 2026 09:59
4439521 to
2768957
Compare
…nfig Signed-off-by: kyteinsky <kyteinsky@gmail.com>
kyteinsky
force-pushed
the
fix/long-deletes
branch
from
May 25, 2026 10:57
2768957 to
a10e8ce
Compare
Merged
kyteinsky
added a commit
that referenced
this pull request
May 26, 2026
## 5.4.0-beta0 - 2026-05-26 ### Added - add network embedding batching (#276) @fcharlaix-opendsi - add kubernetes support and reverse content/indexing flow (#284) @kyteinsky @marcelklehr - add gh workflows for docker builds and do separate cpu, cuda and rocm (vulkan) images (#295) @kyteinsky ### Changed - update readme according to the latest changes (#300) @kyteinsky - bump llama_cpp_python to 0.3.23 (#301) @kyteinsky ### Fixed - improve loadSources error handling (#288) @kyteinsky - fix(pgvector): add chunking to prevent long list of args in queries (#290) @kyteinsky - fix(pgvector): make doc deletion query faster (#289) @kyteinsky
kyteinsky
added a commit
that referenced
this pull request
Jun 24, 2026
## 5.4.0 - 2026-06-24 ### Highlights - The indexing direction has been reversed now. Instead of the context_chat PHP app sending documents to the context_chat_backend ExApp, the ExApp downloads the documents from the server according to a list obtained from the PHP app. This also means that the `occ context_chat:scan` command serves no purpose and has been removed. Indexing should be smoother and run continuously now. - Kubernetes support to scale the CPU computation - Separate docker images for CPU, CUDA and ROCM (uses Vulkan) instead of one heavy CUDA/CPU image - CUDA 12.8 is shipped in the CUDA image so the host drivers should be updated to this at the minimum. ### Added - add network embedding batching (#276) @fcharlaix-opendsi - add kubernetes support and reverse content/indexing flow (#284) @kyteinsky @marcelklehr - add gh workflows for docker builds and do separate cpu, cuda and rocm (vulkan) images (#295) @kyteinsky ### Changed - update readme according to the latest changes (#300) @kyteinsky - bump llama_cpp_python to 0.3.23 (#301) @kyteinsky - move task types to the backend (#321) @kyteinsky - adjust comment in Dockerfile regarding RTX5090 support (#316) @kyteinsky ### Fixed - improve loadSources error handling (#288) @kyteinsky - fix(pgvector): add chunking to prevent long list of args in queries (#290) @kyteinsky - fix(pgvector): make doc deletion query faster (#289) @kyteinsky - drop latin-1 decode in source title and userIds (#306) @kyteinsky - handle validation errors of files and content providers individually (#308) @kyteinsky - prevent race condition in vectordb tables creation (#308) @kyteinsky - pass actual error in the error object (#308) @kyteinsky - add container hostname to /etc/hosts to silence sudo warning (#311) @sanzakicesarr ## 🤖 AI (if applicable) - [ ] The content of this PR was partly or fully generated using AI Signed-off-by: kyteinsky <kyteinsky@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI logging for slow queries has also been enabled, not sure if we will see that in the CI though.
Sample output for the slow deletion query where a missing index on the
source_idforeign key in access_list table was the culprit.Calculated time: 3.495 + 0.310 + 0.129 = 3.934 ms
Actual time: 201177.123 ms or 201 s
(put the chunking part in a different PR)