feat: show preview thumbnails in the list view - #83
Conversation
Fill the NcListItem icon slot with a small (40px, 80px requested for hidpi) lazy-loaded preview thumbnail, using the same etag cache-busting as the grid view. getPreviewUrl() gained a size parameter so the grid keeps its 300px previews. Falls back to a document icon when the preview request fails; mimeFallback=true keeps that case rare. Includes rebuilt assets. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Stacked on #79's branch, so it inherits that PR's problems. Base branch is DetailsThe feature diff itself is small and clean — no blockers in the code:
Test coverage — the real gap. No existing test (grid or list, old or new) covers
Suggested path: hold until #79 is resolved, then rebase this onto the redone base, pull in |
|
Superseded by #87 — rebased onto current |
Adds four rules covering what came up while redoing #79/#83 this session: reuse existing design tokens over hardcoded values, extract components only for genuine multi-site duplication (as its own commit unless the component is new to the feature), prefer @nextcloud/vue over hand-rolled markup, and structure code for testability without extracting solely to reach a test. Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
Every other rule in this file explains its motivating incident in the commit message or PR body, never inside the instructional text itself — #79, #83, #84, and #100's own diagnosis are all discussed there, not quoted in AGENTS.md. "see #100" broke that pattern and adds nothing: the DAV SEARCH orderby/limit example is already self-contained, and a bare PR number means nothing to a future reader without the context this conversation had. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
|
Superseded by #87, now merged as bf7e76b. Attribution carried over: the feature commit on #87 is the version that landed — rebased onto current Closing this one. |
Fill the NcListItem icon slot with a small (40px, 80px requested for hidpi) lazy-loaded preview thumbnail, using the same etag cache-busting as the grid view. getPreviewUrl() gained a size parameter so the grid keeps its 300px previews. Falls back to a document icon when the preview request fails; mimeFallback=true keeps that case rare.
Includes rebuilt assets.
🤖 AI (if applicable)