fix(album): roll back failed database transactions - #3760
Merged
Merged
Conversation
susnux
approved these changes
Aug 17, 2026
Collaborator
|
Linting needs to be fixed |
artonge
approved these changes
Aug 19, 2026
susnux
force-pushed
the
jtr/fix-album-transaction-rollbacks
branch
from
August 19, 2026 17:00
c558a2f to
e2ef90b
Compare
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
susnux
force-pushed
the
jtr/fix-album-transaction-rollbacks
branch
from
August 22, 2026 10:06
e2ef90b to
cdf95e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure album database transactions are rolled back when an exception occurs during multi-step operations.
Prevents partial collaborator updates or album deletions when a later database operation fails.
setCollaborators()fails.delete().\Throwableso both exceptions and PHP errors cannot leave a transaction open.Since this was a tiny fix didn't think bother to use the
TTransactionalhelper.馃 AI (if applicable)